Fbopt_depreciated #353
Closed
Fbopt_depreciated #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #353 +/- ##
==========================================
- Coverage 95.35% 93.35% -2.01%
==========================================
Files 131 136 +5
Lines 4633 4968 +335
==========================================
+ Hits 4418 4638 +220
- Misses 215 330 +115
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
smilesun
commented
Sep 11, 2023
domainlab/algos/trainers/fbopt.py
Outdated
| mmu = None | ||
| for miter in range(self.budget_mu_per_step): | ||
| # FIXME: the same mu is tried two times since miter=0 | ||
| mmu = self.dict_addition(self.mmu, miter * self.delta_mu) |
There was a problem hiding this comment.
miter always start from 0, but let miter=0 only make sense for the 1st iteration
saving gamma_d in diva
fixed wrong setting for msel_tr_loss
make it easier to debug crashes
Fbopt plot penalized
… into fbopt_recon_multiplier
Fbopt recon multiplier
|
fb_master is not need anymore, this pr will be closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.