fix chain_node_builder and diva test func #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #350 +/- ##
==========================================
+ Coverage 94.96% 95.22% +0.26%
==========================================
Files 129 129
Lines 4447 4464 +17
==========================================
+ Hits 4223 4251 +28
+ Misses 224 213 -11
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more 📢 Have feedback on the report? Share it here. |
|
You suggested to initialize the nets as ResNets. However, if I do I get an error, which I cannot resolve (see picture). So I used the ConvNet to make it work. 
|
smilesun
requested changes
Sep 7, 2023
domainlab/compos/pcr/request.py
Outdated
| @store_args | ||
| def __init__(self, net_class_d, net_x, net_class_y, i_c, i_h, i_w): | ||
| """net_class_d, net_x and net_class_y are neural networks defined by the user""" | ||
| pass |
There was a problem hiding this comment.
there is no need to use pass here, as long as there is documentation, it is fine, using pass will confuse the reader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.