Merge pull request #614 from marp-team/improve-container-detection

Disable Chrome sandbox if running CLI as root

.circleci/config.yml

@@ -90,6 +90,7 @@ commands:
           command: npm run test:coverage -- --ci -i --reporters=default --reporters=jest-junit
           environment:
             JEST_JUNIT_OUTPUT_DIR: tmp/test-results
+            MARP_TEST_CI: 1
 
       - codecov/upload:
           flags: linux

.github/workflows/test-win.yml

@@ -41,7 +41,7 @@ jobs:
       # https://stackoverflow.com/a/59365905
       - name: Jest
         env:
-          CI: true
+          MARP_TEST_CI: 1
         run: >-
           npm run test:coverage -- --ci -i --reporters=default --reporters=jest-junit --forceExit ||
           npm run test:coverage -- --ci -i --reporters=default --reporters=jest-junit --forceExit --no-cache ||

CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## [Unreleased]
 
+### Fixed
+
+- Disable Chrome sandbox if running CLI as root ([#611](https://github.com/marp-team/marp-cli/issues/611), [#614](https://github.com/marp-team/marp-cli/pull/614))
+
 ### Removed
 
 - Get rid of `sharp` dependency in favor of using browser in JPEG image conversion with WebDriver BiDi ([#610](https://github.com/marp-team/marp-cli/pull/610))

src/browser/browsers/chrome.ts

@@ -87,6 +87,7 @@ export class ChromeBrowser extends Browser {
 
   private async puppeteerArgsEnableSandbox() {
     if (process.env.CHROME_NO_SANDBOX) return false
+    if (process.getuid?.() === 0) return false // Running as root without --no-sandbox is not supported.
     if (isInsideContainer()) return false
     if (await isWSL()) return false
 

src/utils/container.ts

@@ -1,6 +1,6 @@
 import _isInsideContainer from 'is-inside-container'
 
 export const isInsideContainer = () =>
-  isOfficialDockerImage() || (!process.env.CI && _isInsideContainer())
+  isOfficialDockerImage() || (_isInsideContainer() && !process.env.MARP_TEST_CI)
 
 export const isOfficialDockerImage = () => !!process.env.MARP_USER