Skip to content

Commit

Permalink
Don't use custom profile directory when running Firefox on CircleCI
Browse files Browse the repository at this point in the history
  • Loading branch information
yhatt committed Oct 9, 2024
1 parent 059b949 commit 584fcaf
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
1 change: 0 additions & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,6 @@ commands:
command: npm run test:coverage -- --ci -i --reporters=default --reporters=jest-junit
environment:
JEST_JUNIT_OUTPUT_DIR: tmp/test-results
MOZ_LOG: Process:5

- codecov/upload:
flags: linux
Expand Down
10 changes: 5 additions & 5 deletions src/browser/browsers/firefox.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,12 @@ export class FirefoxBrowser extends Browser {
await this.generateLaunchOptions({
...opts,

dumpio: process.env.NODE_ENV === 'test',

// NOTE: Currently Windows path is incompatible with Puppeteer's preparing
userDataDir: (await this.browserInWSLHost())
? undefined
: await this.puppeteerDataDir(),
// FIXME: CircleCI does not work custom user data directory
userDataDir:
!!process.env.CIRCLECI || (await this.browserInWSLHost())
? undefined
: await this.puppeteerDataDir(),
})
)
}
Expand Down

0 comments on commit 584fcaf

Please sign in to comment.