Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to 3.3.0, changes to a copy of 3.1.0. adjusted implementation… #12

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+20 −732
Open

upgrade to 3.3.0, changes to a copy of 3.1.0. adjusted implementation… #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b87c801
upgrade to 3.3.0, changes to a copy of 3.1.0. adjusted implementation…
marlond18 Aug 20, 2021
35e67f2
Merge branch 'main' into hardcodedAttributesAndComparers
marlond18 Aug 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions History of Breaking Changes and Updates.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
# Breaking Changes and Updates
## (3.2.0 to 3.3.0)
- Had to reintroduce 3.1.0 (since 3.2.0 is almost the same as 3.1.0). 3.2.0 appears to have issues with several projects that I haven't been able to reproduce in tests. Another issue with derived classes has been resolved.
## (3.1.0 to 3.2.0)
- In the previous version, the attributes and equality comparer must be exposed, which means that the output build must be a library; was removed ```<IncludeBuildOutput>false</IncludeBuildOutput>```. In the new update, the attributes and equalitycomparers are also included in the generated code making it possible to add ```<IncludeBuildOutput>false</IncludeBuildOutput>``` in the package settings, making the package purely as an analyzer.
## (3.0.0 to 3.1.0)
Expand Down
13 changes: 2 additions & 11 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,18 +20,9 @@ https://www.nuget.org/packages/EMDD.KtEquatable/

`<PackageReference Include="EMDD.KtEquatable" Version="*.*.*" />`

If you intend to use this generator on projects that are intended as libraries to be consumed by other projects make sure to set the `<PrivateAssets>all</PrivateAssets>`. example syntax on your csproj file:
```
<PackageReference Include="EMDD.KtEquatable" Version="3.1.0">
<PrivateAssets>all</PrivateAssets>
</PackageReference>
```
for some reason (which I can't trace as of now), in some cases version 3.2.0 to 3.2.2 produces an error that says the attributes are inaccessible when used on multiple projects in one solution. It seems this only occurs with older pre-existing solutions. (see ([issue](https://github.com/marlond18/EMDD.KtEquatable/issues/11)). the work around is to use version 3.1.0, which is practically the same as 3.2.0

## Breaking Changes and Updates
### (3.1.0 to 3.2.0)
- In the previous version, the attributes and equality comparer must be exposed, which means that the output build must be a library; had to remove ```<IncludeBuildOutput>false</IncludeBuildOutput>```. In the new update, the attributes and equalitycomparers are also included in the generated code making it possible to add ```<IncludeBuildOutput>false</IncludeBuildOutput>``` in the package settings, making the package purely as an analyzer.

## (3.2.0 to 3.3.0)
- Had to reintroduce 3.1.0 (since 3.2.0 is almost the same as 3.1.0). 3.2.0 appears to have issues with several projects that I haven't been able to reproduce in tests. Another issue with derived classes has been resolved.
see [History of Breaking Changes and Updates](https://github.com/marlond18/EMDD.KtEquatable/blob/main/History%20of%20Breaking%20Changes%20and%20Updates.md)

## Usage
Expand Down
Loading