Add javadoc

markusweigelt · Feb 22, 2024 · bc1ac23 · bc1ac23
1 parent 61874fb
commit bc1ac23
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 11 deletions.
diff --git a/Kitodo/src/main/java/org/kitodo/production/forms/dataeditor/GalleryMediaContent.java b/Kitodo/src/main/java/org/kitodo/production/forms/dataeditor/GalleryMediaContent.java
@@ -218,7 +218,9 @@ public boolean isMediaPartial() {
     }
 
     /**
-     * @return
+     * Get the media partial of physical division.
+     *
+     * @return The media partial or null
      */
     public MediaPartial getMediaPartial() {
         if (isMediaPartial()) {

diff --git a/Kitodo/src/main/java/org/kitodo/production/forms/dataeditor/MediaPartialsPanel.java b/Kitodo/src/main/java/org/kitodo/production/forms/dataeditor/MediaPartialsPanel.java
@@ -70,14 +70,6 @@ public Map<LogicalDivision, MediaPartial> getMediaPartialDivisions() {
         return mediaPartialDivisions;
     }
 
-    public boolean isSelectedMediaPartialDivision(Map.Entry<LogicalDivision, MediaPartial> mediaPartialDivision) {
-        mediaSelection = dataEditor.getGalleryPanel().getLastSelection();
-        if (Objects.nonNull(mediaPartialDivision) && Objects.nonNull(mediaSelection)) {
-            return mediaSelection.getValue().equals(mediaPartialDivision.getKey());
-        }
-        return false;
-    }
-
     /**
      * Validate the duration of the media.
      *

diff --git a/Kitodo/src/main/webapp/WEB-INF/templates/includes/metadataEditor/partials/media-detail.xhtml b/Kitodo/src/main/webapp/WEB-INF/templates/includes/metadataEditor/partials/media-detail.xhtml
@@ -26,7 +26,7 @@
         <ui:fragment
                 rendered="#{mediaProvider.hasMediaViewVariant(selectedGalleryMediaContent) and (fn:startsWith(selectedGalleryMediaContent.mediaViewMimeType, 'video') or fn:startsWith(selectedGalleryMediaContent.mediaViewMimeType, 'audio'))}">
 
-            <p:outputPanel id="mediaDetailMediaContainer" >
+            <p:outputPanel id="mediaDetailMediaContainer">
 
                 <ui:include
                         src="/WEB-INF/templates/includes/metadataEditor/partials/media-detail-audio-waveform-tools.xhtml">

diff --git a/Kitodo/src/main/webapp/pages/metadataEditor.xhtml b/Kitodo/src/main/webapp/pages/metadataEditor.xhtml
@@ -233,7 +233,7 @@
                                               value="#{selectedGalleryMediaContent.getMediaPartial()}"/>
                                     <h:outputText styleClass="columnHeading mediaPartialHeading"
                                                   value="(#{msgs.start}:#{mediaPartial.begin}, #{msgs.duration}:#{mediaPartial.extent})"
-                                                  rendered="#{selectedGalleryMediaContent.isMediaPartial()}"
+                                                  rendered="#{selectedGalleryMediaContent.isMediaPartial() and mediaPartial not null}"
                                                   a:data-media-partial-start="#{mediaPartial.begin}"
                                                   a:data-media-partial-duration="#{mediaPartial.extent}"/>
                                 </ui:fragment>