Update master after cran submission (#31)

* fix for cran submission
markusdumke · Jan 3, 2018 · c222b39 · c222b39
1 parent bf871fd
commit c222b39
Show file tree

Hide file tree

Showing 7 changed files with 18 additions and 307 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -6,9 +6,6 @@ cache: packages
 
 warnings_are_errors: true
 
-r_github_packages:
-  - jimhester/lintr
-
 r:
 - devel
 
@@ -17,9 +14,7 @@ before_install:
 - Rscript -e 'devtools::install_deps()'
 
 after_success:
-- Rscript -e 'covr::codecov(type = "all")'
-- Rscript -e 'source("tests/testthat/helper_lint.R")'
-- Rscript -e 'lintr::lint_package(linters = linters)'
+- Rscript -e 'covr::codecov(type = "tests")'
 
 notifications:
   slack:

diff --git a/DESCRIPTION b/DESCRIPTION
@@ -3,16 +3,18 @@ Type: Package
 Title: Reinforcement Learning
 Version: 0.1.0
 Authors@R: person("Markus", "Dumke", email = {"[email protected]"}, role = c("aut", "cre"))
-Description: Reinforcement learning environments and algorithms. Algorithms can be used 
-    with function approximation, eligibility traces and experience replay.
+Description: Implements reinforcement learning environments and algorithms as described in Sutton & Barto (1998, ISBN:0262193981).
+    The Q-Learning algorithm can be used with different types of function approximation 
+    (tabular and neural network), eligibility traces (Singh & Sutton (1996) <doi:10.1007/BF00114726>) 
+    and experience replay (Mnih et al. (2013) <arXiv:1312.5602>).
 License: MIT + file LICENSE
 Encoding: UTF-8
 LazyData: true
 Depends: R (>= 3.0.0)
 RoxygenNote: 6.0.1
 BugReports: https://github.com/markusdumke/reinforcelearn/issues
 URL: http://markusdumke.github.io/reinforcelearn
-SystemRequirements: (Python and gym only required if Gym environments are used)
+SystemRequirements: (Python and gym only required if gym environments are used)
 Imports:
     checkmate (>= 1.8.4),
     R6 (>= 2.2.2),

diff --git a/LICENSE b/LICENSE
@@ -1,8 +1,2 @@
-YEAR: 2017
-COPYRIGHT HOLDER: Markus Dumke
-
-Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
-
-The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+YEAR: 2018
+COPYRIGHT HOLDER: Markus Dumke
diff --git a/NEWS.md b/NEWS.md
@@ -1 +1,4 @@
+# reinforcelearn 0.1.0
+
+* Initial release.
 * Added a `NEWS.md` file to track changes to the package.
diff --git a/cran-comments.md b/cran-comments.md
@@ -1,3 +1,9 @@
+## Resubmission
+This is a resubmission. In this version I have:
+
+* Updated the Description field in DESCRIPTION to include references to relevant papers.
+* Removed tests which used code from lintr.
+
 ## Test environments
 * local x86_64-w64-mingw32/x64 (64-bit), R 3.4.3
 * linux_gnu x_86_64, R Under development (unstable) (2017-12-22 r73943) on travis-ci
@@ -6,7 +12,7 @@
 
 0 errors | 0 warnings | 1 note
 
-* This is a new release.
+* New submission
 
 ## Reverse dependencies
 

diff --git a/tests/testthat/helper_lint.R b/tests/testthat/helper_lint.R
diff --git a/tests/testthat/test_lint.R b/tests/testthat/test_lint.R