aggregateDesigns fix #139
Merged
aggregateDesigns fix #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also speed up the test a little. Closes #138.
jwbowers
approved these changes
Nov 8, 2024
|
Made another change that should harden it a bit and improve readability, in 42b9004 on branch i138-aggD. Could you test again against your private example, @jwbowers? (I restarted the CI checks and it still passes; see "Checks" tab here on GH. If it works for you too, feel free to just merge it into main w/o add'l comment if appropriate.) |
|
This works on my private example too. Thanks much for the quick work on this Ben. Your solutions are much nicer than the ones I was considering. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to fix the problem identified in #138, at least with the reprex given there. As far as I can tell, whoever coded it (me I think) left in an stray errant line that ought to have been taken out. Jake, would you mind checking that this also fixed the trouble on your private example?