Use a resolver for table conversion #12
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the behavior of the table conversion code action so that it uses a code action resolver instead of a command. A conflict results when more than one instance of the language server registers a command with the same ID, so we can't register a command with a constant name during language server initialization.
In order to use commands for something like this, we'd need to append some unique identifier to the command ID. In this specific case, using a resolver to decouple the edit from the code action provider seemed like a more idiomatic solution.
This PR also updates the version of Markdoc and introduces support for the
config.validation.environment
variable, defaulting its value tolanguage-server
. This allows custom validation functions to identify the context in which they are being executed.