Fix quick pick for "... does not exist" err, cleanup #569
+44
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…run AHK v2 script
mark-wiemer
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To persist settings, we have to persist an entire object. That's why it wasn't working before. However, it doesn't seem trivial to fetch only the workspace config, we have to fetch the entire config (workspace, user, global). We don't know which properties came from which target by default, so for now we are pasting the entire config into workspace settings.
In the future, we could iterate through each property of the fetched object, find its configuration target (as ahk2/src/extension.ts already does), and only paste the workspace settings into, well, the workspace settings.
Quick pick fix is entirely in ahk2, other changes here are: