Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add color-based token recognition #99

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

philipbelesky
Copy link
Collaborator

This is very much a draft/tracking PR, the code below is just the first stage in integrating a standalone prototype that produces edges and center-points based on color recognition.

Since #25 was initially opened, I'm assuming the preference is for this functionality to be encapsulated into the main component. My initial thoughts would be that this would require:

  • An additional input array (list of colors to match from)
  • An additional output array (tree of edge Curves for each color)
  • An additional output array (tree of center Point3D for each color)
  • A parameter for color threshold/leniency that could be integrated into the slider UI

I guess the new input/outputs could be shown/hidden based on if this analysis type is engaged. But there may not be much need given the component ends up being very tall in practice due to the sliding panels.

As previously mentioned, the intent is for this to be merged after a proper 2.0 release. Also, let me know if there's anything else to do on the 2.0 release front?

@philipbelesky philipbelesky added new feature Adding new functionality enhancement New feature or request labels Feb 8, 2022
@philipbelesky philipbelesky self-assigned this Feb 8, 2022
@mariuszhermansdorfer
Copy link
Owner

FYI @philipbelesky, I'm on holidays for the next 2 weeks and won't be able to look into this.
Will get back to you in the first week of March.

@mariuszhermansdorfer
Copy link
Owner

Agreed - let's focus on the 2.0 release and add this later. I will prepare the Yak package and publish it as pre-release. Would appreciate it if you could test it before we roll it out to the community.

@mariuszhermansdorfer mariuszhermansdorfer added this to the Release 2.2 milestone Mar 29, 2022
@mariuszhermansdorfer
Copy link
Owner

@philipbelesky, thanks for testing it with V2.

Could you please rebase this to master? It's updated now and it would be good to start with a clean slate.
Also, let's open a dedicated issue to discuss the direction.

@philipbelesky philipbelesky changed the base branch from feature/SandWorm2-0 to master March 29, 2022 22:25
@philipbelesky philipbelesky changed the title Add color-based token recognition (#25) Add color-based token recognition Mar 29, 2022
@philipbelesky philipbelesky marked this pull request as draft March 29, 2022 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new feature Adding new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants