-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add color-based token recognition #99
base: master
Are you sure you want to change the base?
Add color-based token recognition #99
Conversation
FYI @philipbelesky, I'm on holidays for the next 2 weeks and won't be able to look into this. |
Agreed - let's focus on the 2.0 release and add this later. I will prepare the Yak package and publish it as pre-release. Would appreciate it if you could test it before we roll it out to the community. |
@philipbelesky, thanks for testing it with V2. Could you please rebase this to master? It's updated now and it would be good to start with a clean slate. |
This is very much a draft/tracking PR, the code below is just the first stage in integrating a standalone prototype that produces edges and center-points based on color recognition.
Since #25 was initially opened, I'm assuming the preference is for this functionality to be encapsulated into the main component. My initial thoughts would be that this would require:
Curves
for each color)Point3D
for each color)I guess the new input/outputs could be shown/hidden based on if this analysis type is engaged. But there may not be much need given the component ends up being very tall in practice due to the sliding panels.
As previously mentioned, the intent is for this to be merged after a proper 2.0 release. Also, let me know if there's anything else to do on the 2.0 release front?