Skip to content

Commit

Permalink
Integrate PR Feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
mackoj authored and marinofelipe committed Apr 21, 2024
1 parent 6af77f1 commit 489ffc5
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
5 changes: 3 additions & 2 deletions Sources/App/Providers/BinarySizeProvider/AppManager.swift
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,9 @@ final class AppManager {
}

func generateArchive() throws {
let workingDirectory = fileManager.currentDirectoryPath
var cmdXCConfig: String = ""
if let xcconfig, let customXCConfigURL = URL(string: FileManager.default.currentDirectoryPath)?.appendingPathComponent(xcconfig.path) {
if let xcconfig, let customXCConfigURL = URL(string: workingDirectory)?.appendingPathComponent(xcconfig.path) {
cmdXCConfig = "-xcconfig \(customXCConfigURL.path)"
}
let command: ConsoleMessage = """
Expand All @@ -117,7 +118,7 @@ final class AppManager {

let output = try Shell.run(
command.text,
workingDirectory: fileManager.currentDirectoryPath,
workingDirectory: workingDirectory,
verbose: verbose,
timeout: nil
)
Expand Down
6 changes: 2 additions & 4 deletions Sources/Run/SwiftPackageInfo.swift
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,6 @@ struct AllArguments: ParsableArguments {
],
help: """
A valid relative local directory path that point to a file of type `.xcconfig`
- Note: For local packages full paths are discouraged and unsupported.
"""
)
var xcconfig: URL? = nil
Expand Down Expand Up @@ -160,12 +159,11 @@ extension ParsableCommand {
)
}

if let isValidLocalCustomFile, isValidLocalCustomFile == false {
if isValidLocalCustomFile == false {
throw CleanExit.message(
"""
Error: Invalid argument '--xcconfig <url>'
Usage: The URL must be either:
- A relative local file path that has point to a `.xcconfig` file, e.g. `../other-dir/CustomConfiguration.xcconfig`
Usage: The URL must be a relative local file path that has point to a `.xcconfig` file, e.g. `../other-dir/CustomConfiguration.xcconfig`
"""
)
}
Expand Down

0 comments on commit 489ffc5

Please sign in to comment.