Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loop to selection list when pressing q while playing #23

Merged
merged 5 commits into from
Aug 12, 2023

Conversation

hannesbraun
Copy link
Contributor

This adds the planned feature from the README for looping back to the selection list after pressing q.

Additionally, I added a caching mechanism for the stations retrieved through the radio browser API. For me, this would be one of the main reasons why I even want to loop back to the selection list. Depending on the current internet speed, loading the station list might take a while. This cache can optionally be disabled using the new --no-station-cache flag (either to save memory or to force a reload).

If there's something you'd like to have differently, let me know. This is just the way that I would have done it.

Copy link
Owner

@margual56 margual56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything wrong with the implementation. Good job, this is pretty cool!

@margual56 margual56 added the enhancement New feature or request label Aug 12, 2023
@margual56 margual56 merged commit d61b80f into margual56:main Aug 12, 2023
3 checks passed
@hannesbraun hannesbraun deleted the loop-selection-list branch August 12, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants