-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create field through Table view #731
Conversation
[field.name]: field.typeConfig, | ||
}, | ||
}); | ||
saveConfig({ ...config }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Project level field configs, like rich-text or options, and view-level configs like column order and column width are stored separatedly. When updating project config, the view config would be overwritten.
project
and config
are both local variables. Updating project config by local project
would ignore changed config
. Updating view config by local config
right after updating project config here would keep the view config unchanged.
await api.addField(field, value, position); | ||
|
||
updateFieldCfg(field); | ||
updateViewCfg(field, position); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updateFieldCfg
would update project-level field config, while updateViewCfg
will overwrite the stale config in project
with a newer config
. Same reason mentioned in onColumnConfigure
This has been sorely lacking. Thanks for taking the time to implement it! |
How do I turn it off? |
Do you mean you want a setting option to hide this feature? I’d like to know more on your case. And, if possible, could you kindly open up an issue requesting this? |
Updates #692, #709, #197
This PR allows creating new fields in Table view directly, via the
Add field
button at the end of columns, orInsert left/right
button provided in the column drop-down (three-dots
).Important change on dataframe:
List
, and encoded asmultitext
, stay in consistent with Obsidian (see undocumented obsidian-typings)multitext
support is still inplemented byrepeted
text field