Skip to content

Commit

Permalink
Bug 1933655 [wpt PR 49391] - [devtools] Throw adding 2 internal authe…
Browse files Browse the repository at this point in the history
…nticators, a=testonly

Automatic update from web-platform-tests
[devtools] Throw adding 2 internal authenticators

Have devtools throw an error when a client attempts to add an internal
authenticator when there's one already present in the environment. This
is not supported and causes all sorts of issues.

This requires fixing a WPT that did not clean the virtual
authenticator. The WPT passing and not crashing Chrome previously was
luck.

Fixed: 40234612
Change-Id: I25d6e6c3387d0180234c21af157bc0b6ef15f566
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6047769
Reviewed-by: Alex Rudenko <alexrudenkochromium.org>
Auto-Submit: Nina Satragno <nsatragnochromium.org>
Commit-Queue: Alex Rudenko <alexrudenkochromium.org>
Cr-Commit-Position: refs/heads/main{#1388668}

--

wpt-commits: d05c649bf1f54d0eec5e87d33b3ac7e8cdd1cc1b
wpt-pr: 49391

UltraBlame original commit: f78c1db19ae4e6d5718816cb622033f7c276b061
  • Loading branch information
marco-c committed Dec 1, 2024
1 parent 8d88eb5 commit 2095860
Showing 1 changed file with 13 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,9 @@
parent
)
;
const
authenticator
=
await
window
.
Expand Down Expand Up @@ -314,6 +317,16 @@
name
;
}
await
window
.
test_driver
.
remove_virtual_authenticator
(
authenticator
)
;
parent
.
postMessage
Expand Down

0 comments on commit 2095860

Please sign in to comment.