Updated CFC to use Apache Commons #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 8, 2016 00:22
…odec to implement Base32 encoding/decoding. Also Added new function getOTPQRURL() which return the a QR code URL you can put straight in to an image tag
displague
reviewed
Nov 28, 2016
| @@ -72,6 +72,11 @@ component output="false" { | |||
| return 'otpauth://totp/#arguments.email#?secret=#arguments.key#'; | |||
| } | |||
|
|
|||
| public string function getOTPQRURL(required string OTPURL){ | |||
| local.qrURL = "https://chart.googleapis.com/chart?chs=200x200&cht=qr&chl=200x200&chld=M|0&cht=qr&chl="; | |||
There was a problem hiding this comment.
It seems like a bad idea to send your secret tokens to Google. They seem nice but I assume this grants thousands of Google employees the ability to grep your referral domain from their logs and get a very small list of possible secrets for any TOTP enabled account on your domain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
I've update the code base to now use the Apache Commons Codec and removed the needs to have a separate .JS file to create the QR code