Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix comparison against nil for the UUID type #295

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Fix comparison against nil for the UUID type #295

merged 2 commits into from
Oct 29, 2024

Conversation

asabil
Copy link
Contributor

@asabil asabil commented Oct 29, 2024

No description provided.

taniabogatsch
taniabogatsch requested changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@taniabogatsch taniabogatsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I only have a small remark w.r.t. the test.

appender_test.go Show resolved Hide resolved
@taniabogatsch taniabogatsch merged commit 02af7ce into marcboeker:main Oct 29, 2024
6 checks passed
@taniabogatsch
Copy link
Collaborator

Thanks!

@asabil asabil deleted the fix/handle-nil-uuid branch October 29, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taniabogatsch taniabogatsch taniabogatsch approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asabil @taniabogatsch