support better error messages #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apocelipes
force-pushed
the
feat-better-error
branch
from
e4abd21 to
f74d6fa
Compare
|
This is ready for review. |
|
Thanks @apocelipes, we'll have a look at it. |
taniabogatsch
requested changes
Jul 1, 2024
There was a problem hiding this comment.
Hi, @apocelipes, thanks for the PR! I agree that go-duckdb should support better error messages. I've left one main question: How should go-duckdb handle (or even just distinguish) between duckdb errors and driver errors?
apocelipes
force-pushed
the
feat-better-error
branch
from
748cfc4 to
c4a66b1
Compare
taniabogatsch
approved these changes
Jul 1, 2024
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #238.