Add support for named parameters #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcboeker
reviewed
Jun 5, 2024
Comment on lines
+65
to
+77
| // override with ordinal if set | ||
| for _, v := range args { | ||
| if v.Ordinal == i+1 { | ||
| arg = v | ||
| } | ||
| } | ||
|
|
||
| // override with name if set | ||
| for _, v := range args { | ||
| if v.Name == paramName { | ||
| arg = v | ||
| } | ||
| } |
There was a problem hiding this comment.
It is in 3 passes to set different priorities. For example in case the client code or a wrapper library is setting/generating NamedValues with both a Name and an Ordinal as a fallback mechanism.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for named parameters.
It tries to keeps old behaviour intact, but introduces some vague interpretation since it can mix named and non-named parameters. Possibly a better alternative is to check whether named or positional parameters are used and do strict validation.