Replacement scan #208
Merged
Replacement scan #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taniabogatsch
requested changes
Jun 5, 2024
There was a problem hiding this comment.
Hi @ajzo90, thanks for the PR! I've added a few comments and questions.
taniabogatsch
requested changes
Jun 6, 2024
taniabogatsch
approved these changes
Jun 6, 2024
marcboeker
reviewed
Jun 10, 2024
|
@ajzo90 Thanks for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple implementation of replacement scan API in duckdb.
Registers a callback function that gets called when a query refer to a table that not exists in duckdb as per https://duckdb.org/docs/api/c/replacement_scans.
Currently limited to supporting int64 and string as table function arguments, but this seems like a limitation in duckdb C API.