Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR alters the appender to use
duckdb::data_chunks
instead of the DuckDB appender.The function
AppendRow()
is used the same as before, except instead of row-wise insertions, the rows are inserted intodata_chunks
, allowing us to append whole chunks at a time. When a chunk is full, a new one is automatically allocated. WhenFlush()
is called, all thedata_chunks
are appended and destroyed in one go.Currently
appender_test.go
takes the same time as before (0.12s). However, I plan to tweak and optimize this function to increase its efficiency.Finally, a big benefit of transitioning to the
data_chunk
framework, is that it allows for the easy addition of nested types which will be coming in a future PR.Relevant issue: #135
CC: @taniabogatsch