refactor: fix linter warnings

marcboeker · Jun 6, 2024 · cc2ccf5 · cc2ccf5
1 parent 23801de
commit cc2ccf5
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/appender_test.go b/appender_test.go
@@ -527,9 +527,10 @@ func TestAppenderNullStruct(t *testing.T) {
 	for res.Next() {
 		var row any
 		err = res.Scan(&row)
-		if i == 0 {
+		switch i {
+		case 0:
 			require.NoError(t, err)
-		} else if i == 1 {
+		case 1:
 			require.Equal(t, nil, row)
 		}
 		i++

diff --git a/appender_vector.go b/appender_vector.go
@@ -282,9 +282,10 @@ func (vec *vector) setCString(rowIdx C.idx_t, val any) {
 	}
 
 	var str string
-	if vec.duckdbType == C.DUCKDB_TYPE_VARCHAR {
+	switch vec.duckdbType {
+	case C.DUCKDB_TYPE_VARCHAR:
 		str = val.(string)
-	} else if vec.duckdbType == C.DUCKDB_TYPE_BLOB {
+	case C.DUCKDB_TYPE_BLOB:
 		str = string(val.([]byte)[:])
 	}
 

diff --git a/rows.go b/rows.go
@@ -166,7 +166,7 @@ func scan(vector C.duckdb_vector, rowIdx C.idx_t) (any, error) {
 	case C.DUCKDB_TYPE_STRUCT:
 		return scanStruct(columnType, vector, rowIdx)
 	case C.DUCKDB_TYPE_MAP:
-		return scanMap(columnType, vector, rowIdx)
+		return scanMap(vector, rowIdx)
 	case C.DUCKDB_TYPE_UUID:
 		hugeInt := get[C.duckdb_hugeint](vector, rowIdx)
 		return hugeIntToUUID(hugeInt), nil
@@ -289,7 +289,7 @@ func get[T any](vector C.duckdb_vector, rowIdx C.idx_t) T {
 	return xs[rowIdx]
 }
 
-func scanMap(ty C.duckdb_logical_type, vector C.duckdb_vector, rowIdx C.idx_t) (Map, error) {
+func scanMap(vector C.duckdb_vector, rowIdx C.idx_t) (Map, error) {
 	list, err := scanList(vector, rowIdx)
 	if err != nil {
 		return nil, err