Skip to content

Commit

Permalink
Use build tags for Arrow implementation (#205)
Browse files Browse the repository at this point in the history
* perf: gate arrow implementation behind build tag

* chore: use no_duckdb_arrow build tags instead

* docs: update arrow install instructions

* Re-build static libraries

* chore: revert Re-build static libraries

* Revert "Re-build static libraries"

This reverts commit c49895c.

---------

Co-authored-by: ayuhito <[email protected]>
  • Loading branch information
ayuhito and ayuhito authored Jun 6, 2024
1 parent 0348edb commit 0b53b1e
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 0 deletions.
6 changes: 6 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,12 @@ for rdr.Next() {
}
```

The Arrow interface is a heavy dependency. If you do not need it, you can disable it by passing `-tags=no_duckdb_arrow` to `go build`. This will be made opt-in in V2.

```sh
go build -tags="no_duckdb_arrow"
```

## Vendoring

If you want to vendor a module containing `go-duckdb`, please use `modvendor` to include the missing header files and libraries.
Expand Down
2 changes: 2 additions & 0 deletions arrow.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
//go:build !no_duckdb_arrow

package duckdb

/*
Expand Down
2 changes: 2 additions & 0 deletions arrow_test.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
//go:build !no_duckdb_arrow

package duckdb

import (
Expand Down

0 comments on commit 0b53b1e

Please sign in to comment.