v1.2.0 #65
Merged
v1.2.0 #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setup full typescript support
Updating to Maplibre 3.3.0
adding fix from dev-v1.2.0
Converters
Co-authored-by: Craig O'Connor <[email protected]>
Co-authored-by: Craig O'Connor <[email protected]>
Co-authored-by: Craig O'Connor <[email protected]>
Co-authored-by: Craig O'Connor <[email protected]>
Add polyline
ENH now supporting all the languages supported by OMT
REM geojson-validation
* ADD visitor language * WIP language logic revamp * ADD language from style metadata * ENH language definition * REM got rid of commented code * ENH adjusted the size of secondary lang with visitor language mode * Update src/Map.ts Co-authored-by: Craig O'Connor <[email protected]> * Update src/Map.ts Co-authored-by: Craig O'Connor <[email protected]> * ENH from review * ENH added things from review --------- Co-authored-by: Craig O'Connor <[email protected]>
* ADD visitor language * ADD helper for addong polygon from geojson * ADD map.addPolygon * REM some data * Update src/Map.ts Co-authored-by: Craig O'Connor <[email protected]> * ENH unused import * Update src/Map.ts Co-authored-by: Craig O'Connor <[email protected]> * Update src/Map.ts Co-authored-by: Craig O'Connor <[email protected]> * ENH from review --------- Co-authored-by: Craig O'Connor <[email protected]>
* first attempt * reduce typescript warnings * reduce typescript warnings * add final todo * zoom ceiling; bounds bug fix; pitch off by default; unique style; simplify; etc. * fix key * simplify typescript * review part 1; cleaner types; better comments * remove zoomCeiling; its essentially minZoom * improve readability of minimap options input * bug fix; adjustments * add style downwind functions; requested changes * slight adjustment * set lang fix * improve types --------- Co-authored-by: Craig O'Connor <[email protected]>
* WIP point layer helper * WIP better clusters * WIP changed point helper options * ADD color ramps with builtins * WIP simpler set of options * ADD non linear resampling on color ramps * ADD color ramp doc * ADD outline color for points * ADD point outline settings * REM colorRamp arg and use only pointColor instead * DONE Map.addPoint
* WIP point layer helper * WIP better clusters * WIP changed point helper options * ADD color ramps with builtins * WIP simpler set of options * ADD non linear resampling on color ramps * ADD color ramp doc * ADD outline color for points * ADD point outline settings * REM colorRamp arg and use only pointColor instead * DONE Map.addPoint * ADD radius and weight being both zoom and property driven * ADD zoom comensation param to point helper * FIX minmaxzoom and added MapTiler cloud source with uuid * DOC polyline helper section in readme * WIP readme * DOC done with documenting helpers * DOC color ramp doc * DOC fix * DOC * ENH cleaning unused types * ENH updating eslint * FIX dependecy audit * ENH export types and a better style path * ENH refectoring to place the helpers in a dedicated place * FIX typo
* WIP point layer helper * WIP better clusters * WIP changed point helper options * ADD color ramps with builtins * WIP simpler set of options * ADD non linear resampling on color ramps * ADD color ramp doc * ADD outline color for points * ADD point outline settings * REM colorRamp arg and use only pointColor instead * DONE Map.addPoint * ADD radius and weight being both zoom and property driven * ADD zoom comensation param to point helper * FIX minmaxzoom and added MapTiler cloud source with uuid * DOC polyline helper section in readme * WIP readme * DOC done with documenting helpers * DOC color ramp doc * DOC fix * DOC * ENH cleaning unused types * ENH updating eslint * FIX dependecy audit * ENH export types and a better style path * ENH refectoring to place the helpers in a dedicated place * ENH changed TypeScript moduleResolution from Node to Bundler
* WIP point layer helper * WIP better clusters * WIP changed point helper options * ADD color ramps with builtins * WIP simpler set of options * ADD non linear resampling on color ramps * ADD color ramp doc * ADD outline color for points * ADD point outline settings * REM colorRamp arg and use only pointColor instead * DONE Map.addPoint * ADD radius and weight being both zoom and property driven * ADD zoom comensation param to point helper * FIX minmaxzoom and added MapTiler cloud source with uuid * DOC polyline helper section in readme * WIP readme * DOC done with documenting helpers * DOC color ramp doc * DOC fix * DOC * ENH cleaning unused types * ENH updating eslint * FIX dependecy audit * ENH export types and a better style path * ENH refectoring to place the helpers in a dedicated place * ENH changed TypeScript moduleResolution from Node to Bundler * UP now using Maplibre v3.5.2 (strict)
petrsloup
requested changes
Nov 1, 2023
There was a problem hiding this comment.
There are now some lint errors, but the workflow does not fail.
The format/lint rules no actually make the changes to the local files, so that's probably why the workflow does not fail.
It would probably be better to have to versions of these: format/lint just for checking (useful for CI and just checking) and format:fix/lint:fix that actually make to changes (for running during development).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RD-173