ensure canvas is not painted when hide and show event is fired.

maptalks · Oct 14, 2024 · d76c3cf · d76c3cf
1 parent 8b1f082
commit d76c3cf
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 7 deletions.
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/src/layer/Layer.ts b/src/layer/Layer.ts
@@ -423,7 +423,9 @@ class Layer extends JSONAble(Eventable(Renderable(Class))) {
             if (renderer && map && map.getRenderer()) {
                 //fire show in next frame to make sure layer is shown
                 map.getRenderer().callInNextFrame(() => {
-                    this.fire('show');
+                    map.getRenderer().callInNextFrame(() => {
+                        this.fire('show');
+                    });
                 });
             } else {
                 /**
@@ -459,7 +461,9 @@ class Layer extends JSONAble(Eventable(Renderable(Class))) {
             if (renderer && map && map.getRenderer()) {
                 //fire hide in next frame to make sure layer is hidden
                 map.getRenderer().callInNextFrame(() => {
-                    this.fire('hide');
+                    map.getRenderer().callInNextFrame(() => {
+                        this.fire('hide');
+                    });
                 });
             } else {
                 /**

diff --git a/test/geometry/AGeometryRemoveHideSpec.js b/test/geometry/AGeometryRemoveHideSpec.js
@@ -123,11 +123,8 @@ function test(geometry, context, fn, done) {
             })
         });
         layer.once('hide', function () {
-
-            map.once('frameend', function () {
-                expect(isDrawn(testPoints, context.container)).not.to.be.ok();
-                done();
-            })
+            expect(isDrawn(testPoints, context.container)).not.to.be.ok();
+            done();
         });
         fn();
     });