-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs restructuring, adding funding and training pages #377
Conversation
In this PR we restructure the documentation pages a little, and add pages that detail the main funding sources and training resources.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only issue is the wrongly placed comment about spec-model.md
needing rewriting (see below), but since this is a purely internal comment that is not publicly visible, no need to request changes for that (you might still want to update that though, if only to remember to re-write the correct page :D ).
There is a bit of a thin line between Funding and general acknowledgements, and we could end up acknowledging the python developers for providing python, but I do think it appropriate to acknowledge separately the LinkML project due to the significant role the framework played in the development of the schema.
These comments were orginally created during brainstorming and I forgot to remove them before committing..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all good to me.
In this PR we restructure the documentation pages a little, and add pages that detail the main funding sources and training resources.
docs/
have been added/updated if necessarymake test
has been run locallytests have been added/updated (if applicable)CHANGELOG.md has been updated.