Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs restructuring, adding funding and training pages #377

Merged
merged 3 commits into from
Aug 2, 2024

Conversation

matentzn
Copy link
Collaborator

In this PR we restructure the documentation pages a little, and add pages that detail the main funding sources and training resources.

  • docs/ have been added/updated if necessary
  • make test has been run locally
  • tests have been added/updated (if applicable)
  • CHANGELOG.md has been updated.

In this PR we restructure the documentation pages a little, and add pages that detail the main funding sources and training resources.
gouttegd
gouttegd previously approved these changes Jul 31, 2024
Copy link
Contributor

@gouttegd gouttegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only issue is the wrongly placed comment about spec-model.md needing rewriting (see below), but since this is a purely internal comment that is not publicly visible, no need to request changes for that (you might still want to update that though, if only to remember to re-write the correct page :D ).

mkdocs.yml Outdated Show resolved Hide resolved
mkdocs.yml Show resolved Hide resolved
mkdocs.yml Show resolved Hide resolved
src/docs/funding.md Show resolved Hide resolved
src/docs/funding.md Show resolved Hide resolved
There is a bit of a thin line between Funding and general acknowledgements, and we could end up acknowledging the python developers for providing python, but I do think it appropriate to acknowledge separately the LinkML project due to the significant role the framework played in the development of the schema.
These comments were orginally created during brainstorming and I forgot to remove them before committing..
@matentzn matentzn requested a review from gouttegd July 31, 2024 12:55
Copy link
Contributor

@gouttegd gouttegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me.

@matentzn matentzn merged commit d2b9d7e into master Aug 2, 2024
3 checks passed
@matentzn matentzn deleted the restructure-docs240731 branch August 2, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants