-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SSSOM rewire to rewire method #403
base: master
Are you sure you want to change the base?
Conversation
@ehartley would you be interested to take this on? I created the basic outline of the method (without testing anything of course). This will solve the sssom- rewiring problem at least. We can think of a generic client later, but note that due to the possibly complex handling of prefix map and metadata it makes sense to have a solid solution here as well. |
@matentzn yes, I can take this on. |
Super! |
#426 is about fixing the reconciliation code, which also effectively includes the solution to this |
@ehartley I added the code that standardizes a MSDF based on recent updates. You can continue on here. I realize I may have misunderstood what was going on here before, so I highly suggest writing several clear, explicit examples as unit tests before starting any implementation. |
This PR introduces the possibility of rewiring an SSSOM table based on another SSSOM table. This is in scope for sssom-py because of the complex handing of SSSOM mapping set metadata.