-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete all validation files since they may be old #318
base: master
Are you sure you want to change the base?
Conversation
All of them? Oh wow, we must have not tested roundtripping for ages! See https://github.com/mapping-commons/sssom-py/blob/validate-data-files/tests/test_conversion.py#L68 Can you reintroduce some of these checks? I felt quite protected having them there! |
Ok, so when I put in created files in the
Apparently s1 is not == s2.
So the
The documentation says:
Update:
|
@hrshdhgd can you update this PR? |
Fixes #317