Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Struct for zoom level #118

Merged
merged 7 commits into from
Jun 1, 2022
Merged

Struct for zoom level #118

merged 7 commits into from
Jun 1, 2022

Conversation

ybiletskyi
Copy link
Contributor

@ybiletskyi ybiletskyi commented May 30, 2022 •
edited by maxammann
Loading

Created a struct for ZoomLevel

💻 Examples

🚨 Test instructions

✔️ PR Todo

maxammann
maxammann requested changes May 31, 2022
View reviewed changes
Copy link
Collaborator

@maxammann maxammann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the picky review :D

10 lines of code = 10 issues.
500 lines of code = "looks fine."

maplibre/src/coords.rs Outdated Show resolved Hide resolved
maplibre/src/coords.rs Outdated Show resolved Hide resolved
maplibre/src/coords.rs Outdated Show resolved Hide resolved
maplibre/src/coords.rs Outdated Show resolved Hide resolved
maplibre/src/coords.rs Outdated Show resolved Hide resolved
maplibre/src/coords.rs Outdated Show resolved Hide resolved
maplibre/src/coords.rs Outdated Show resolved Hide resolved
@maxammann
Copy link
Collaborator

android build is failing because of github actions, lets just merge this and see what happens

@maxammann maxammann merged commit 05dbdac into maplibre:main Jun 1, 2022
@ybiletskyi ybiletskyi deleted the zoom-level-struct branch June 3, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxammann maxammann maxammann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a struct for ZoomLevel
2 participants
@ybiletskyi @maxammann