optimize dockerfile #671
Open
optimize dockerfile #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution. Can you provide a little more information about the purpose of this change? |
jingsam
commented
Nov 18, 2018
| @@ -3,8 +3,8 @@ FROM ubuntu:16.04 | |||
|
|
|||
| # Update repos and install dependencies | |||
| RUN apt-get update \ | |||
| && apt-get -y upgrade \ | |||
There was a problem hiding this comment.
We should not run apt-get upgrade in docker, use a new version of image instead, eg. Ubuntu:18.04.
jingsam
commented
Nov 18, 2018
| && apt-get -y upgrade \ | ||
| && apt-get -y install build-essential libsqlite3-dev zlib1g-dev | ||
| && apt-get -y install build-essential libsqlite3-dev zlib1g-dev \ | ||
| && rm -rf /var/lib/apt/lists/* |
There was a problem hiding this comment.
Remove apt cache, which make the docker image smaller and cleaner.
|
I add a review for the changes, please check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.