Proof-of-concept for theme props approach #29
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #26
The first commit on this PR does a few things:
theme
prop that fits the convention proposed in Extendtheme*
props to accept functions that receive the default class list #26: string values are appended, function values replace.applyTheme
function that we can use to apply the same convention all over the place.theme*
props, since they are for advanced users, and explain them all in one place.If we like this approach, I guess the next step would be to modify all the existing components to follow the new convention. To be clear, it would a breaking change: usage of
theme*
strings right now would have to adjust to accommodate the change. The intended benefit of the change is to help the most common use case and the less advanced users. If you disagree and think we should just stick with the currenttheme*
behavior — wheretheme*
props take a string and that string replaces the class list wholesale — please let me know! cc @tristen @mapbox/studio @frontendHere are some shots of what the docs look like: