Improve departure announcement (#654)

mapbox · Sep 28, 2017 · d6dfe12 · d6dfe12
1 parent 1ee18b0
commit d6dfe12
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 4 deletions.
diff --git a/MapboxCoreNavigation/Constants.swift b/MapboxCoreNavigation/Constants.swift
@@ -150,3 +150,8 @@ let milesToMeters = 1609.34
  The mimimum speed value before the user is snapped to the route. This is used to overcome inaccurate course values when a user's speed is low.
  */
 public var RouteControllerMinimumSpeedThresholdForSnappingUserToRoute: CLLocationSpeed = 2
+
+/**
+ The minimum distance threshold used for giving a "Continue" type instructions.
+ */
+public var RouteControllerMinDistanceForContinueInstruction: CLLocationDistance = 2_000
diff --git a/MapboxCoreNavigation/SpokenInstructionFormatter.swift b/MapboxCoreNavigation/SpokenInstructionFormatter.swift
@@ -72,10 +72,34 @@ public class SpokenInstructionFormatter: NSObject {
         // We only want to announce this special depature announcement once.
         // Once it has been announced, all subsequnt announcements will not have an alert level of low
         // since the user will be approaching the maneuver location.
-        let isDeparture = routeProgress.currentLegProgress.currentStep.maneuverType == .depart && alertLevel == .depart
-        let didCompleteManeuver = routeProgress.currentLegProgress.currentStep.distance > 2_000 && routeProgress.currentLegProgress.alertUserLevel == .low
-        if isDeparture || didCompleteManeuver {
-            if isDeparture && upcomingStepDuration < linkedInstructionMultiplier {
+        let isStartingDeparture = routeProgress.currentLegProgress.currentStep.maneuverType == .depart && (alertLevel == .depart || alertLevel == .low)
+        if let currentInstruction = currentInstruction, isStartingDeparture {
+            if routeProgress.currentLegProgress.currentStep.distance > RouteControllerMinDistanceForContinueInstruction {
+                text = currentInstruction
+            } else if upcomingStepDuration > linkedInstructionMultiplier {
+                // If the upcoming step is an .exitRoundabout or .exitRotary, don't link the instruction
+                if let followOnStep = routeProgress.currentLegProgress.followOnStep, followOnStep.maneuverType == .exitRoundabout || followOnStep.maneuverType == .exitRotary {
+                    text = upComingInstruction
+                } else {
+                    let phrase = escapeIfNecessary(routeStepFormatter.instructions.phrase(named: .twoInstructionsWithDistance))
+                    text = phrase.replacingTokens { (tokenType) -> String in
+                        switch tokenType {
+                        case .firstInstruction:
+                            return currentInstruction
+                        case .secondInstruction:
+                            return upComingInstruction
+                        case .distance:
+                            return maneuverVoiceDistanceFormatter.string(from: userDistance)
+                        default:
+                            fatalError("Unexpected token \(tokenType)")
+                        }
+                    }
+                }
+            } else {
+                text = upComingInstruction
+            }
+        } else if routeProgress.currentLegProgress.currentStep.distance > RouteControllerMinDistanceForContinueInstruction && routeProgress.currentLegProgress.alertUserLevel == .low {
+            if isStartingDeparture && upcomingStepDuration < linkedInstructionMultiplier {
                 let phrase = escapeIfNecessary(routeStepFormatter.instructions.phrase(named: .twoInstructionsWithDistance))
                 text = phrase.replacingTokens { (tokenType) -> String in
                     switch tokenType {