Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-komposer version and dependencies is outdated #6

Open
markshust opened this issue Jul 13, 2016 · 6 comments
Open

react-komposer version and dependencies is outdated #6

markshust opened this issue Jul 13, 2016 · 6 comments

Comments

@markshust
Copy link

The react-komposer version is very behind, and newer composeWithMobx isn't included.

markshust added a commit to markshust/mantra-core that referenced this issue Jul 13, 2016
markshust added a commit to markshust/mantra-core that referenced this issue Jul 13, 2016
@markshust
Copy link
Author

Created pr #7

@smeijer
Copy link

smeijer commented Jul 14, 2016

Update would indeed be very welcome. In my case for the method setStubbingMode.

markshust added a commit to markshust/mantra-core that referenced this issue Jul 14, 2016
@markshust
Copy link
Author

@smeijer thanks for this, added to the PR. let me know if there are any other things missing.

@superandrew213
Copy link

I think that react-komposer should not be included in mantra. You can just add it yourself to your project and we can avoid these updates

@markshust
Copy link
Author

That's the whole point of having helpers in mantra though (to simplify things). If that is the case, those helpers should be removed from mantra.

@superandrew213
Copy link

Changing this

import { compose, composeAll, useDeps } from 'mantra-core';

to this

import { useDeps } from 'react-simple-di';
import { compose, merge } from 'react-komposer';

is not that complex IMO. We also don't have to rely/depend on the maintainers to update their repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants