Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate imports from mantra-core #8

Closed
markshust opened this issue Jul 13, 2016 · 2 comments
Closed

deprecate imports from mantra-core #8

markshust opened this issue Jul 13, 2016 · 2 comments

Comments

@markshust
Copy link

I'm wondering if the pulled in imports from react-simple-di and react-komposer should perhaps be deprecated?

Right now react-komposer is on version 1.9.0 and there are some pending pr's for react-simple-di. I'm concerned this repo that imports them into mantra-core package will always be slightly outdated unless an automated build is setup. Since this is the case, I'm wondering if these wrapper functions should be deprecated.

@chmanie
Copy link

chmanie commented Jul 13, 2016

I was worried about similar things. In the end, this package mainly is one small file that you can easily fork/copy and include in your project. I actually ended up doing exactly that (see also #5).

@markshust
Copy link
Author

Thanks. I did wind up forking & updating. I think in a larger project, this wrapper helps so we don't have many lines of imports (same reason we are using DI).

I'll close this out, as I opened a ticket to update mantra-core with the latest versions at #6 -- we can still discuss here though if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants