Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only Redraw ROI and Subsequently Spectrum if isVisible is True #2396

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

JackEAllen
Copy link
Collaborator

Issue

Closes #2376

Description

Prevent redrawing of ROI's and subsequently spectrum line plots where the ROI isVisible property is set to False

Testing

Manually Tested

Acceptance Criteria

  • Selecting Normalise Spectrum when in ROI view does not display the Spectrum for any ROIs including the RITS_ROI where isVisible is set to False.

Documentation

How have you changed the documentation to reflect your changes? All changes should be noted in the appropriate file in docs/release_notes

docs/release_notes/next/fix-2376-resolve_spectrum_visiblity_when_normalisation_toggled_on_and_off

@JackEAllen JackEAllen force-pushed the 2376_disable_drawing_of_invisible_roi_spectrum branch from 242dd47 to 469732b Compare November 13, 2024 15:06
@coveralls
Copy link

coveralls commented Nov 13, 2024

Coverage Status

coverage: 74.227% (+0.007%) from 74.22%
when pulling 5d00d72 on 2376_disable_drawing_of_invisible_roi_spectrum
into 507d6e8 on main.

@JackEAllen JackEAllen marked this pull request as ready for review November 13, 2024 15:30
@JackEAllen JackEAllen force-pushed the 2376_disable_drawing_of_invisible_roi_spectrum branch from 469732b to f540d7a Compare November 14, 2024 11:36
@JackEAllen JackEAllen force-pushed the 2376_disable_drawing_of_invisible_roi_spectrum branch from f540d7a to 5d00d72 Compare November 14, 2024 16:36
Copy link
Collaborator

@samtygier-stfc samtygier-stfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the issue for me.

@samtygier-stfc samtygier-stfc added this pull request to the merge queue Nov 15, 2024
Merged via the queue into main with commit e027cbb Nov 15, 2024
8 checks passed
@samtygier-stfc samtygier-stfc deleted the 2376_disable_drawing_of_invisible_roi_spectrum branch November 15, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spectrum Line Plot from Image Mode ROI visible in ROI Mode When Normalisation Selected Within ROI Mode
3 participants