Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Rocky8 in workflow #2308

Merged
merged 4 commits into from
Aug 7, 2024
Merged

Switch to Rocky8 in workflow #2308

merged 4 commits into from
Aug 7, 2024

Conversation

samtygier-stfc
Copy link
Collaborator

@samtygier-stfc samtygier-stfc commented Aug 7, 2024

Issue

Closes #2296

Description

Switch the docker workflow from centos 7 to rocky 8
Remove an obsolete makefile

Testing & Acceptance Criteria

Check that the rocky workflow is running successfully

E.g. https://github.com/mantidproject/mantidimaging/actions/runs/10285623294/job/28464327831?pr=2308

Documentation

Updated installation docs

@coveralls
Copy link

coveralls commented Aug 7, 2024

Coverage Status

coverage: 74.316%. remained the same
when pulling ed66905 on 2296-rocky-workflow
into c2f19c2 on main.

@samtygier-stfc samtygier-stfc marked this pull request as ready for review August 7, 2024 14:52
Copy link
Collaborator

@MikeSullivan7 MikeSullivan7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good, Rocky Testing runs as expected. Thanks for finishing off the Rocky migration!

@MikeSullivan7 MikeSullivan7 added this pull request to the merge queue Aug 7, 2024
@samtygier-stfc samtygier-stfc merged commit 79a43a1 into main Aug 7, 2024
6 checks passed
@samtygier-stfc samtygier-stfc deleted the 2296-rocky-workflow branch August 7, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CentOS 7 EOL
3 participants