Fix conda package build with python 3.12 #2306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samtygier-stfc
changed the title
Not on conda-forge for python 3.12 and we were not using it
samtygier-stfc
force-pushed
the
2305-fix-build
branch
from
a745a7c to
ebbc824
Compare
|
Package build can be seen at https://github.com/mantidproject/mantidimaging/actions/runs/10285386953/job/28463520421?pr=2306 You can see that the |
samtygier-stfc
force-pushed
the
2305-fix-build
branch
from
ebbc824 to
6ae29a4
Compare
MikeSullivan7
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #2305
Description
Remove conda-verify as it causes our build environment to use python 3.11 which causes build failure.
Testing
I have made a test commit to run the build action.
Acceptance Criteria
Check that build stage in ebbc824 ran
Documentation
Not needed