Exclude builtin test.support modules from being loaded with Operation Modules #2299
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #2298
Description
In both
mantidimaging/core/operations/loader.py
andpackaging/PackageWithPyInstaller.py
we now check if the module name aligns with that in the builtin test modules and exclude it if it does.Testing
make check
Acceptance Criteria
rebuild dev env
make a Windows build via
packaging/PackageWithPyInstaller.py
check that the Windows build does not contain any AssertionErrors related to the Operations modules.
Documentation
release note