Update cil to 24.0 #2184
Merged
Update cil to 24.0 #2184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samtygier-stfc
force-pushed
the
2183-update-cil
branch
from
24ef961 to
e970233
Compare
samtygier-stfc
added
the
rebuild_docker 🐋
samtygier-stfc
removed
the
rebuild_docker 🐋
|
After performing some operations on the Flower dataset, the preview of the CIL recon looks good:
The recon itself runs fine and the results look sensible :) |
MikeSullivan7
previously approved these changes
May 1, 2024
|
I'll need to rebase this to fix the conflicts (and have the tests pass reliably) |
samtygier-stfc
force-pushed
the
2183-update-cil
branch
from
68f9420 to
8144b44
Compare
|
Rebase done |
MikeSullivan7
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #2183
Description
This also required numpy and scipy updates, and a small change to how we iterate calls to PDHG
Testing & Acceptance Criteria
Test that reconstructing with CIL still gives sensible results
Documentation
release notes