Image scroller for live view #1917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackEAllen
requested changes
Sep 4, 2023
There was a problem hiding this comment.
Looks good! Just small suggestion to add a class docstring. Once #1915 has merged in and this branch is rebased, happy to approve. 👍
samtygier-stfc
force-pushed
the
1916-zscroller
branch
from
8a3d33e to
306d1df
Compare
samtygier-stfc
force-pushed
the
1916-zscroller
branch
from
306d1df to
0c05d17
Compare
JackEAllen
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #1916
Needs rebase after #1915 is mergedDescription
Extract ZSlider into its own module, and add type annotations
Add a ZSlider to the live viewer
Hook up ZSlider to adjust range as images arrive, and to show the selected image
A bit of refactoring to move image list state into the model
Testing & Acceptance Criteria
Check that Live View still functions well as a non interactive tool, updating correctly as new images arrive
Check that the range of the zslider matches the number of images in the live directory
Check that it is possible to scroll through the images
Check that corrupt images do not cause problems (frame will just be blank for files that could not be read)
Documentation
Release notes