Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Muon HDF4 loaders to muon library #38477

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

robertapplin
Copy link
Contributor

@robertapplin robertapplin commented Dec 5, 2024

Description of work

This PR moves the LoadMuonNexus1 and LoadMuonNexus2 algorithms to the Framework/Muon library instead of Framework/DataHandling. The base class for these two algorithms (LoadMuonNexus) is also moved. These two algorithms are the only algorithms in Mantid used to load HDF4 Nexus files. The plan is to isolate these two algorithms within the Framework/Muon library, and then convert the code to use the HDF4 API directly instead of the Nexus API (in a future PR).

Part of #38214

To test:

Check that the LoadMuonNexus1 and LoadMuonNexus2 algorithms are still accessible in the DataHandling section of the algorithms on Workbench

This does not require release notes because its an internal change

Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@robertapplin robertapplin added Muon Issues and pull requests related to muons Maintenance Unassigned issues to be addressed in the next maintenance period. ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS labels Dec 5, 2024
@robertapplin robertapplin added this to the Release 6.12 milestone Dec 5, 2024
@robertapplin robertapplin marked this pull request as ready for review December 5, 2024 13:27
@robertapplin robertapplin force-pushed the 38214-move-muon-hdf4-loaders branch 2 times, most recently from cfd68f3 to f448571 Compare December 6, 2024 16:09
@robertapplin robertapplin force-pushed the 38214-move-muon-hdf4-loaders branch from f448571 to 5b4b27e Compare December 6, 2024 16:55
@robertapplin robertapplin force-pushed the 38214-move-muon-hdf4-loaders branch from 5b4b27e to 5b3aee4 Compare December 6, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS Maintenance Unassigned issues to be addressed in the next maintenance period. Muon Issues and pull requests related to muons
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

2 participants