Move Muon HDF4 loaders to muon library #38477
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
This PR moves the
LoadMuonNexus1
andLoadMuonNexus2
algorithms to theFramework/Muon
library instead ofFramework/DataHandling
. The base class for these two algorithms (LoadMuonNexus
) is also moved. These two algorithms are the only algorithms in Mantid used to load HDF4 Nexus files. The plan is to isolate these two algorithms within theFramework/Muon
library, and then convert the code to use the HDF4 API directly instead of the Nexus API (in a future PR).Part of #38214
To test:
Check that the
LoadMuonNexus1
andLoadMuonNexus2
algorithms are still accessible in the DataHandling section of the algorithms on WorkbenchThis does not require release notes because its an internal change
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeepers
will take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.