Merge pull request #196 from manifoldco/improvements/get-oauth-poll

Use GET request for OAuth polling

CHANGELOG.md

@@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 - GitHub identity -- register a new account, login to or link an existing account to GitHub
 - GitHub identity -- update GitHub app ClientID
+- GitHub identity -- Use GET for state polling
 - Reference to go-manifold updated to 0.9.1 release for verification code change
 
 ## [0.12.0] - 2017-11-30

cmd/github.go

@@ -19,7 +19,6 @@ import (
 	"github.com/manifoldco/manifold-cli/config"
 	"github.com/manifoldco/manifold-cli/api"
 	"github.com/manifoldco/manifold-cli/generated/identity/client/authentication"
-	"github.com/manifoldco/manifold-cli/generated/identity/models"
 )
 
 var (
@@ -78,19 +77,17 @@ func githubWithCallback(ctx context.Context, cfg *config.Config, a *analytics.An
 	timeout := time.After(pollingTimeout)
 	tick := time.Tick(pollingTick)
 
-	op := authentication.NewPostTokensOauthPollParamsWithContext(ctx)
-	op.SetBody(&models.OAuthAuthenticationPoll{
-		Secret: &state,
-	})
+	op := authentication.NewGetTokensOauthPollParamsWithContext(ctx)
+	op.Secret = state
 	for {
 		select {
 		case <-timeout:
 			return cli.NewExitError("Unable to fetch authentication", -1)
 		case <-tick:
-			loginResp, linkResp, err := identityClient.Identity.Authentication.PostTokensOauthPoll(op)
+			loginResp, linkResp, err := identityClient.Identity.Authentication.GetTokensOauthPoll(op)
 			if err != nil {
 				switch err.(type) {
-				case *authentication.PostTokensOauthPollNotFound:
+				case *authentication.GetTokensOauthPollNotFound:
 					continue
 				default:
 					return err

specs/identity.yaml

@@ -56,17 +56,16 @@ paths:
           schema:
             $ref: '#/definitions/Error'
   /tokens/oauth/poll:
-    post:
+    get:
       security: []
       summary: Poll the exchange of a third-party OAuth 2 token for valid authentication
       parameters:
-        - name: body
-          in: body
+        - name: secret
+          in: query
           description: |
-            OAuth state information
+            The state secret to poll for authorization
+          type: string
           required: true
-          schema:
-            $ref: '#/definitions/OAuthAuthenticationPoll'
       tags:
         - Authentication
       responses: