Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub Action + Docker tag suffix #16

Merged
merged 8 commits into from
Dec 11, 2023
Merged

GitHub Action + Docker tag suffix #16

merged 8 commits into from
Dec 11, 2023

Commits on Jan 26, 2023

  1. Metadata to make a GitHub Action

    @ysbaddaden
    ysbaddaden committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    2d7694b View commit details
    Browse the repository at this point in the history

  2. Add options to suffix a tag and pass docker build options

    @ysbaddaden
    ysbaddaden committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    095db0e View commit details
    Browse the repository at this point in the history

  3. GHA: use a JavaScript action 

    The composite action didn't work as expected (the action's
`action.sh` and `build.sh` weren't accessible), so I replaced the
shell script with a tiny JavaScript bootstrap, that will properly
collect the action inputs and generate a simple local build.sh and
calls it.

Note that we couldn't use a Docker container action, because we
couldn't access the host docker ending, and would need to add both
docker cli and docker server to the docker container...
    @ysbaddaden
    ysbaddaden committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    5efa342 View commit details
    Browse the repository at this point in the history

  4. fix: disable shellcheck warning (BUILD_OPTS _must_ be splat)

    @ysbaddaden
    ysbaddaden committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    7131975 View commit details
    Browse the repository at this point in the history

  5. fixup! fix: disable shellcheck warning (BUILD_OPTS _must_ be splat)

    @ysbaddaden
    ysbaddaden committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    751e1cc View commit details
    Browse the repository at this point in the history

  6. Tests for -t suffix and -o buildOptions build arguments

    @ysbaddaden
    ysbaddaden committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    7a1d82b View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2023

  1. Remove already removed latest flag 

    See 5d99055
    @matiasgarciaisaia
    matiasgarciaisaia committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    6459017 View commit details
    Browse the repository at this point in the history

  2. Use current action/checkout version 

    The old one was depracted due to its base NodeJS version
    @matiasgarciaisaia
    matiasgarciaisaia committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    d2613cd View commit details
    Browse the repository at this point in the history