GitHub Action + tag suffix + build options #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sigh, the composite action doesn't work: it runs the |
ysbaddaden
force-pushed
the
feature/actual-github-action
branch
2 times, most recently
from
8121748
to
6c3980c
Compare
The composite action didn't work as expected (the action's `action.sh` and `build.sh` weren't accessible), so I replaced the shell script with a tiny JavaScript bootstrap, that will properly collect the action inputs and generate a simple local build.sh and calls it. Note that we couldn't use a Docker container action, because we couldn't access the host docker ending, and would need to add both docker cli and docker server to the docker container...
ysbaddaden
force-pushed
the
feature/actual-github-action
branch
from
c58fc89
to
404e79d
Compare
|
It's finally working. You can see a test run here for example: Is it worth spending more time writing GitHub Actions? No. A single repository with a bunch of Bash or Ruby scripts would be much better. |
|
ping @matiasgarciaisaia |
|
Do you mind adding some tests for the new flags? I can give them a try, otherwise. |
|
Sorry @ysbaddaden - I've deleted the |
|
@matiasgarciaisaia I used the opportunity to rebase from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7 by adding the necessary
action.ymlmetadata to run build script directly, and the necessaryaction.shshell script to transform the action inputs into environment variables, .Also provides two new options, one to pass a tag suffix, for example
-nextto have image tags such as:1.2.3-nextor:dev-next, and another one to pass options to the docker build command, for example--build gemfile=Gemfile.next. Those options allows to build 2 variants of CDx for example, the current one with Rails 4.2 and the next one with Rails 5.0.