Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove gcc warning #321

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove gcc warning #321

wants to merge 2 commits into from

Conversation

Alex-PLACET
Copy link
Collaborator

No description provided.

@Alex-PLACET Alex-PLACET self-assigned this Jan 3, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 3, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.72289% with 16 lines in your changes missing coverage. Please review.

Project coverage is 91.67%. Comparing base (bf02e6b) to head (ce6d09f).

Files with missing lines Patch % Lines
src/layout/run_end_encoded_array.cpp 79.48% 16 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #321      +/-   ##
==========================================
- Coverage   91.82%   91.67%   -0.15%     
==========================================
  Files          77       78       +1     
  Lines        5796     5805       +9     
==========================================
  Hits         5322     5322              
- Misses        474      483       +9
Flag Coverage Δ
unittests 91.67% <80.72%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Alex-PLACET Alex-PLACET marked this pull request as ready for review January 3, 2025 20:33
Alex-PLACET
Alex-PLACET commented Jan 6, 2025
View reviewed changes
src/layout/run_end_encoded_array.cpp
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved the implementation code to a cpp file. This can be discussed. For performance reason, inlining could be preferable.

Copy link
Collaborator

@JohanMabille JohanMabille Jan 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why that change? I don't have any strong opinion about it, but if we keep a cpp file, then the existing src/run_encoded_layout.cpp should be merged with it.

JohanMabille
JohanMabille previously approved these changes Jan 8, 2025
View reviewed changes
@JohanMabille JohanMabille dismissed their stale review January 8, 2025 09:03

Wrong approval

JohanMabille
JohanMabille reviewed Jan 8, 2025
View reviewed changes
include/sparrow/array_api.hpp
@@ -46,7 +46,7 @@ namespace sparrow
/**
* Constructs an empty array.
*/
SPARROW_API array() = default;
array() = default;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?Are default members considered as inline on Windows?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohanMabille JohanMabille JohanMabille left review comments

@DerThorsten DerThorsten Awaiting requested review from DerThorsten

At least 1 approving review is required to merge this pull request.

Assignees

@Alex-PLACET Alex-PLACET

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Alex-PLACET @JohanMabille