-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugged binary layout #312
Merged
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,98 @@ | ||
| // Man Group Operations Limited | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| #pragma once | ||
|
|
||
| #include <algorithm> | ||
| #include <ranges> | ||
| #include <vector> | ||
|
|
||
| #if defined(__cpp_lib_format) | ||
| # include <format> | ||
| #endif | ||
|
|
||
| namespace sparrow | ||
| { | ||
| /** | ||
| * The class vector_view describes an object that can refer to a constant contiguous | ||
| * sequence of T with the first element of the sequence at position zero. It is similar | ||
| * to string_view, but for arbitrary T. You can consider it as a span or range supporting | ||
| * const operations only, and comparison operators. | ||
| */ | ||
| template <class T> | ||
| class vector_view : public std::span<T> | ||
| { | ||
| public: | ||
|
|
||
| using base_type = std::span<T>; | ||
| using value_type = typename base_type::value_type; | ||
|
|
||
| using base_type::base_type; | ||
|
|
||
| explicit operator std::vector<value_type>() const noexcept | ||
| { | ||
| return std::vector<value_type>(this->begin(), this->end()); | ||
| } | ||
| }; | ||
|
|
||
| template <class T> | ||
| constexpr bool operator==(const vector_view<T>& lhs, const vector_view<T>& rhs) | ||
| { | ||
| return std::ranges::equal(lhs, rhs); | ||
| } | ||
|
|
||
| template <class T> | ||
| constexpr bool operator==(const vector_view<T>& lhs, const std::vector<std::decay_t<T>>& rhs) | ||
| { | ||
| return std::ranges::equal(lhs, rhs); | ||
| } | ||
|
|
||
| template <class T> | ||
| constexpr std::compare_three_way_result<T> | ||
| operator<=>(const vector_view<T>& lhs, const vector_view<T>& rhs) | ||
| { | ||
| return std::lexicographical_compare_three_way(lhs.begin(), lhs.end(), rhs.begin(), rhs.end()); | ||
| } | ||
|
|
||
| template <class T> | ||
| constexpr std::compare_three_way_result<T> | ||
| operator<=>(const vector_view<T>& lhs, const std::vector<std::decay_t<T>>& rhs) | ||
| { | ||
| return std::lexicographical_compare_three_way(lhs.begin(), lhs.end(), rhs.begin(), rhs.end()); | ||
| } | ||
| } | ||
|
|
||
| #if defined(__cpp_lib_format) | ||
| template <class T> | ||
| struct std::formatter<sparrow::vector_view<T>> | ||
| { | ||
| constexpr auto parse(std::format_parse_context& ctx) | ||
| { | ||
| return ctx.begin(); // Simple implementation | ||
| } | ||
|
|
||
| auto format(const sparrow::vector_view<T>& vec, std::format_context& ctx) const | ||
| { | ||
| std::format_to(ctx.out(), "<"); | ||
| if (!vec.empty()) | ||
| { | ||
| for (std::size_t i = 0; i < vec.size() - 1; ++i) | ||
| { | ||
| std::format_to(ctx.out(), "{}, ", vec[i]); | ||
| } | ||
| } | ||
| return std::format_to(ctx.out(), "{}>", vec.back()); | ||
| } | ||
| }; | ||
| #endif | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm if you can use the std here, it's means that we don't need the sparrow::lexicographical_compare_three_way implementation anymore (because we use newer version of Xcode I guess).
We should remove this code in another PR.