Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DecimalArray #307

Merged
merged 38 commits into from
Dec 17, 2024
Merged

DecimalArray #307

merged 38 commits into from
Dec 17, 2024

Conversation

DerThorsten
Copy link
Collaborator

No description provided.

@DerThorsten DerThorsten marked this pull request as ready for review December 16, 2024 07:00
Alex-PLACET
Alex-PLACET reviewed Dec 16, 2024
View reviewed changes
include/sparrow/layout/decimal_array.hpp Outdated Show resolved Hide resolved
include/sparrow/types/data_type.hpp Outdated Show resolved Hide resolved
include/sparrow/utils/decimal.hpp Outdated


T m_value;
//int m_precision;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To remove ?

include/sparrow/utils/large_int.hpp Outdated Show resolved Hide resolved
@DerThorsten DerThorsten merged commit 1998e0a into man-group:main Dec 17, 2024
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohanMabille JohanMabille JohanMabille approved these changes

@Alex-PLACET Alex-PLACET Alex-PLACET approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DerThorsten @Alex-PLACET @JohanMabille