Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added null_type and implemented null_layout #120

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Added null_type and implemented null_layout #120

merged 2 commits into from
Jun 28, 2024

Conversation

JohanMabille
Copy link
Collaborator

@JohanMabille JohanMabille commented Jun 27, 2024 •
edited
Loading

Fixes #115

@JohanMabille JohanMabille requested a review from Alex-PLACET June 27, 2024 15:42
@JohanMabille JohanMabille marked this pull request as ready for review June 27, 2024 15:50
Alex-PLACET
Alex-PLACET requested changes Jun 28, 2024
View reviewed changes
include/sparrow/data_type.hpp Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang format

include/sparrow/null_layout.hpp Show resolved Hide resolved
include/sparrow/null_layout.hpp Show resolved Hide resolved
include/sparrow/null_layout.hpp Show resolved Hide resolved
include/sparrow/null_layout.hpp Show resolved Hide resolved
test/test_null_layout.cpp Show resolved Hide resolved
test/test_null_layout.cpp Show resolved Hide resolved
include/sparrow/null_layout.hpp Show resolved Hide resolved
Alex-PLACET
Alex-PLACET approved these changes Jun 28, 2024
View reviewed changes
Copy link
Collaborator

@Alex-PLACET Alex-PLACET left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JohanMabille JohanMabille merged commit 90d03b6 into man-group:main Jun 28, 2024
31 checks passed
@JohanMabille JohanMabille deleted the null_layout branch June 28, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alex-PLACET Alex-PLACET Alex-PLACET approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement the null layout for std::nullopt_t
2 participants
@JohanMabille @Alex-PLACET