Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and clarify workaround of access issue with friend functions with msvc #12

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

Klaim
Copy link
Collaborator

@Klaim Klaim commented Mar 7, 2024

I replaced WIN32 by _WIN32 because the first one is defined by headers from window's sdk, not by the compiler, while the second one is defined by the compiler.

Details of the access issue:
https://developercommunity.visualstudio.com/t/Private-member-inaccessible-when-used-in/10448363?q=friend+private

…th msvc

I replaced `WIN32` by `_WIN32` because the first one is defined by headers from window's sdk, not by the compiler, while the second one is defined by the compiler.

Details of the access issue:
https://developercommunity.visualstudio.com/t/Private-member-inaccessible-when-used-in/10448363?q=friend+private
@Klaim Klaim requested review from JohanMabille and jjerphan March 7, 2024 17:20
@JohanMabille JohanMabille merged commit 22189a4 into man-group:main Mar 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants