Use recent gcc/apple-clang with OSX #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macOS 15 has not yet been released. Signed-off-by: Julien Jerphanion <[email protected]>
Reference: actions/runner-images#8282 (comment) Signed-off-by: Julien Jerphanion <[email protected]>
Signed-off-by: Julien Jerphanion <[email protected]>
Klaim
changed the title
Alex-PLACET
approved these changes
Apr 10, 2024
Signed-off-by: Julien Jerphanion <[email protected]>
This reverts commit 0135df3.
Signed-off-by: Julien Jerphanion <[email protected]>
This reverts commit 2576371.
Signed-off-by: Julien Jerphanion <[email protected]>
|
I do not think we need to use gcc with macOS: this is not a requirement for us, at least now. Also the latest version of Apple Clang seems to be bugued (see 2576371). |
Signed-off-by: Julien Jerphanion <[email protected]> Co-authored-by: Klaim <[email protected]>
I named "gcc/apple-clang" because if you try to use the default gcc on OSX (as far as I know) it's actually an alias (or symlink) to apple-clang by default. Thats why this pr didnt try to add gcc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.